[SQL] Improve error messages for validating JSON#5683
Conversation
|
cd6b3d3 to
b474e48
Compare
|
Can we fix the formatting? The line breaks, spacing etc feel inconsistent. |
|
The whole |
mythical-fred
left a comment
There was a problem hiding this comment.
Two blockers — see inline.
sql-to-dbsp-compiler/SQL-compiler/src/main/java/org/dbsp/util/Utilities.java
Outdated
Show resolved
Hide resolved
sql-to-dbsp-compiler/SQL-compiler/src/main/java/org/dbsp/util/Utilities.java
Outdated
Show resolved
Hide resolved
sql-to-dbsp-compiler/SQL-compiler/src/main/java/org/dbsp/util/Utilities.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/dbsp/sqlCompiler/compiler/frontend/calciteCompiler/SqlToRelCompiler.java
Outdated
Show resolved
Hide resolved
This has been formatted by IntelliJ... it should be consistent. But I will take a look to see what you don't like. |
That's the message coming from the Json library I am using, I will massage it, but it will be a very custom solution. |
05e699c to
bef5cbb
Compare
Turns out that the Json handling exception I get already has a nice way to do this. |
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
bef5cbb to
6595531
Compare
Fixes #5677
Describe Manual Test Plan
There are regression tests which validate the implementation.
I also verified that the errors look good in the web ui: see screenshot below
Checklist