[profiler] Don't serialize empty metrics.#5690
Merged
mihaibudiu merged 1 commit intomainfrom Feb 25, 2026
Merged
Conversation
Make the profiles less verbose by only serializing the `labels` field of a metric if it's not empty. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
490f262 to
84fe5b9
Compare
mihaibudiu
approved these changes
Feb 24, 2026
mythical-fred
approved these changes
Feb 24, 2026
| if (metric.labels.length !== 0) { | ||
| metric_id = metric_id + "." + labels; | ||
| if (metric.labels) { | ||
| let labels = metric.labels.map(e => e.join(":")).join("."); |
Collaborator
There was a problem hiding this comment.
Indentation: the body of this if block uses 3 spaces while the surrounding function body uses 4. Minor, but inconsistent with the rest of the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the profiles less verbose by only serializing the
labelsfield of a metric if it's not empty.Describe Manual Test Plan
Tested manually using the web ui and a new profile.
Checklist
Breaking Changes?
Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes