[SLT] Copy cargo.lock before running SLT tests#5705
Merged
mihaibudiu merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
snkas
approved these changes
Feb 26, 2026
mythical-fred
approved these changes
Feb 26, 2026
Collaborator
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM. getCanonicalPath() is the right fix over getAbsolutePath() (resolves .. properly). Utilities.enforce gives a clear throw if the source lock file is missing. temp/ is a checked-in directory so the destination path is always valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Manual Test Plan
I have manually run all the SLT tests that were supposed to run overnight to check that they pass.