Merged
Conversation
mihaibudiu
approved these changes
Feb 27, 2026
| r_stats = get(api_url(f"/pipelines/{pipeline_name}/stats")) | ||
| assert r_stats.status_code == HTTPStatus.OK, (r_stats.status_code, r_stats.text) | ||
| stats = r_stats.json() | ||
| print(stats) |
Member
Author
There was a problem hiding this comment.
It was useful for debugging and I don't think it can hurt in a test.
| StepAction::Step if request.step >= step => Some(Action::Step), | ||
| StepAction::Trigger if request.step >= step => None, | ||
| StepAction::Trigger if request.step >= step => { | ||
| if self.controller.status.unset_step_requested() { |
mythical-fred
suggested changes
Feb 27, 2026
Collaborator
mythical-fred
left a comment
There was a problem hiding this comment.
One test bug that needs fixing before this can merge.
| out = outputs[0] | ||
| assert out.get("config", {}).get("stream") == "v1" | ||
| assert out.get("metrics", {}).get("total_processed_input_records") == 5 | ||
| assert out.get("metrics", {}).get("total_processed_input_steps") == steps |
Collaborator
There was a problem hiding this comment.
Wrong field name: total_processed_input_steps does not exist. The field added to OutputEndpointMetrics is total_processed_steps. This assertion always gets None and will fail once steps > 0.
Member
Author
There was a problem hiding this comment.
This was buggy.
I pushed a new version that adds a type-safe API for these properties and uses it in the test.
ryzhyk
approved these changes
Feb 27, 2026
Signed-off-by: Ben Pfaff <blp@feldera.com>
This doesn't test JSON metrics, which haven't been implemented in multihost and maybe will never need to be. Signed-off-by: Ben Pfaff <blp@feldera.com>
This has been available inside the pipeline for a while, but we forgot to expose it through the API. This fixes that. This also fixes up and enables the corresponding Python integration test. Signed-off-by: Ben Pfaff <blp@feldera.com>
The clock connector requests steps instead of queueing data, but we were ignoring that in multihost. Also, connect the clock only on the first host in a multihost cluster. This fixes a Python integration test for now in multihost, so enable that test. Signed-off-by: Ben Pfaff <blp@feldera.com>
Signed-off-by: feldera-bot <feldera-bot@feldera.com>
mythical-fred
approved these changes
Feb 27, 2026
Collaborator
mythical-fred
left a comment
There was a problem hiding this comment.
Fix looks good — total_processed_steps is now correctly exposed in the API and the test uses it properly. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fixes make more of the Python integration tests pass on multihost.