Skip to content

[SQL] Make sure that cargo.lock exists before compiling Rust#5719

Merged
mihaibudiu merged 1 commit intomainfrom
det-java
Mar 2, 2026
Merged

[SQL] Make sure that cargo.lock exists before compiling Rust#5719
mihaibudiu merged 1 commit intomainfrom
det-java

Conversation

@mihaibudiu
Copy link
Contributor

Hopefully this will fix some nondeterministic errors that appear in CI due to missing cargo.lock files.

The errors look like this:

error[E0308]: mismatched types
   --> /home/ubuntu/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/jemalloc_pprof-0.7.0/src/lib.rs:167:49
    |
167 |         let profile = parse_jeheap(dump_reader, MAPPINGS.as_deref())?;
    |                       ------------              ^^^^^^^^^^^^^^^^^^^ expected `Mapping`, found `pprof_util::Mapping`
    |                       |
    |                       arguments to this function are incorrect
    |
note: two different versions of crate `pprof_util` are being used; two types coming from two different versions of the same crate are different types even if they look the same

Describe Manual Test Plan

Ran Java tests

@mihaibudiu mihaibudiu enabled auto-merge February 27, 2026 18:05
@mihaibudiu mihaibudiu added this pull request to the merge queue Feb 27, 2026
Copy link
Collaborator

@mythical-fred mythical-fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean consolidation — BaseSQLTests.compileAndCheckRust now always gates on skipRust and calls setupCargoLock, eliminating the scattered duplicate patterns that were missing it.

@mihaibudiu mihaibudiu removed this pull request from the merge queue due to a manual request Feb 27, 2026
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
@mihaibudiu mihaibudiu enabled auto-merge March 2, 2026 22:04
@mihaibudiu mihaibudiu added this pull request to the merge queue Mar 2, 2026
Merged via the queue into main with commit 255fb70 Mar 2, 2026
1 check passed
@mihaibudiu mihaibudiu deleted the det-java branch March 2, 2026 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants