Skip to content

clean-up: remove unused functions - #4292

Merged
fluid-e2e-bot[bot] merged 2 commits into
fluid-cloudnative:masterfrom
omerap12:dataset_nodeAffinity
Aug 27, 2024
Merged

clean-up: remove unused functions#4292
fluid-e2e-bot[bot] merged 2 commits into
fluid-cloudnative:masterfrom
omerap12:dataset_nodeAffinity

Conversation

@omerap12

@omerap12 omerap12 commented Aug 23, 2024 •
edited by TrafalgarZZZ
Loading

Copy link
Copy Markdown
Member

Ⅰ. Describe what this PR does

Remove unused functions.

Ⅱ. Does this pull request fix one issue?

Refer to this comment: #991 (comment)

fixes #991

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@fluid-e2e-bot

fluid-e2e-bot Bot commented Aug 23, 2024

Copy link
Copy Markdown

Hi @omerap12. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TrafalgarZZZ TrafalgarZZZ mentioned this pull request Aug 25, 2024
Closed
@omerap12 omerap12 changed the title Dataset node affinity clean-up: remove unused functions Aug 26, 2024
@omerap12
Removed unused code
d8aba10 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
Remove unused imports in jindofsx/worker.go
0a037a4 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@sonarqubecloud

sonarqubecloud Bot commented Aug 26, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@omerap12

omerap12 commented Aug 26, 2024

Copy link
Copy Markdown
Member Author

@TrafalgarZZZ, would you like me to squash my commits?

@omerap12
omerap12 marked this pull request as ready for review August 26, 2024 07:38
@TrafalgarZZZ

TrafalgarZZZ commented Aug 26, 2024

Copy link
Copy Markdown
Member

@TrafalgarZZZ, would you like me to squash my commits?

We will "Squash and merge" your PR to master branch so it's okay.

TrafalgarZZZ
TrafalgarZZZ reviewed Aug 26, 2024
View reviewed changes

@TrafalgarZZZ TrafalgarZZZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @omerap12 for the PR! LGTM!
/lgtm

@cheyang Please take a look and merge it if there's no further comments

@fluid-e2e-bot fluid-e2e-bot Bot added the lgtm label Aug 26, 2024
@cheyang

cheyang commented Aug 27, 2024

Copy link
Copy Markdown
Collaborator

/test fluid-e2e

cheyang
cheyang approved these changes Aug 27, 2024
View reviewed changes

@cheyang cheyang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot

fluid-e2e-bot Bot commented Aug 27, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang

cheyang commented Aug 27, 2024

Copy link
Copy Markdown
Collaborator

Thanks @omerap12 for the PR! LGTM! /lgtm

@cheyang Please take a look and merge it if there's no further comments

LGTM. Thanks @omerap12 and @TrafalgarZZZ

@omerap12

omerap12 commented Aug 27, 2024

Copy link
Copy Markdown
Member Author

Thanks @omerap12 for the PR! LGTM! /lgtm

@cheyang Please take a look and merge it if there's no further comments

LGTM. Thanks @omerap12 and @TrafalgarZZZ

No problem at all. Please ping me if you have any more issues for me to solve 😀

@fluid-e2e-bot
fluid-e2e-bot Bot merged commit 6e33346 into fluid-cloudnative:master Aug 27, 2024
@omerap12
omerap12 deleted the dataset_nodeAffinity branch August 27, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrafalgarZZZ TrafalgarZZZ TrafalgarZZZ left review comments
@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

@TrafalgarZZZ TrafalgarZZZ

Labels

approved lgtm needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURES] Dataset nodeAffinity should support matchFields

3 participants

@omerap12 @TrafalgarZZZ @cheyang