Skip to content

Sort packages, optimize Dockerfile - #4309

Merged
fluid-e2e-bot[bot] merged 1 commit into
fluid-cloudnative:masterfrom
omerap12:issue-4308
Sep 5, 2024
Merged

Sort packages, optimize Dockerfile#4309
fluid-e2e-bot[bot] merged 1 commit into
fluid-cloudnative:masterfrom
omerap12:issue-4308

Conversation

@omerap12

@omerap12 omerap12 commented Sep 4, 2024

Copy link
Copy Markdown
Member

Ⅰ. Describe what this PR does

Sorting package names alphabetically for better readability and combining RUN commands to reduce Docker image layers

Ⅱ. Does this pull request fix one issue?

fixes #4308

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

I see this ENV: https://github.com/fluid-cloudnative/fluid/blob/master/addons/dynamic-mount/ossfs/docker/Dockerfile#L3
Do we want to set this as ARG (instead of hard coded ENV)?

@omerap12
Sort packages, optimize Dockerfile RU
980f367 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@sonarqubecloud

sonarqubecloud Bot commented Sep 4, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@omerap12 omerap12 changed the title Sort packages, optimize Dockerfile RU Sort packages, optimize Dockerfile Sep 4, 2024
@cheyang

cheyang commented Sep 5, 2024

Copy link
Copy Markdown
Collaborator

Ⅰ. Describe what this PR does

Sorting package names alphabetically for better readability and combining RUN commands to reduce Docker image layers

Ⅱ. Does this pull request fix one issue?

fixes #4308

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

I see this ENV: https://github.com/fluid-cloudnative/fluid/blob/master/addons/dynamic-mount/ossfs/docker/Dockerfile#L3 Do we want to set this as ARG (instead of hard coded ENV)?

It would be better if we use ARG instead of ENV. Thanks.

cheyang
cheyang approved these changes Sep 5, 2024
View reviewed changes

@cheyang cheyang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot Bot added the lgtm label Sep 5, 2024
@fluid-e2e-bot

fluid-e2e-bot Bot commented Sep 5, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot
fluid-e2e-bot Bot merged commit 569f6ee into fluid-cloudnative:master Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]Arguments in long RUN instructions should be sorted

2 participants

@omerap12 @cheyang