fix: fix slice init length - #4335
Conversation
|
Hi @cuishuang. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@cuishuang Please fix DCO issue by following the guide in https://github.com/fluid-cloudnative/fluid/pull/4335/checks?check_run_id=31076714246 |
Signed-off-by: cuishuang <imcusg@gmail.com>
Thanks. Signed |
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cuishuang Good catch! Thanks for helping optimizing the code's performance！Look forward to your next contribution! |
Ⅰ. Describe what this PR does
The intention here should be to initialize a slice with a capacity of
len(runtimeInfos)rather than initializing the length of this slice.The online demo: https://go.dev/play/p/q1BcVCmvidW
Ⅱ. Does this pull request fix one issue?
fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews