Fix: fix some typo and log fmt error - #4347
Merged
fluid-e2e-bot[bot] merged 1 commit intoOct 10, 2024
Merged
Conversation
Syspretor
force-pushed
the
fix/fix-some-typo
branch
3 times, most recently
from
October 10, 2024 07:55
9e76914 to
5cb4f7f
Compare
Signed-off-by: jiuyu <guotongyu.gty@alibaba-inc.com>
Syspretor
force-pushed
the
fix/fix-some-typo
branch
from
October 10, 2024 08:10
5cb4f7f to
74f9054
Compare
|
Collaborator
|
/test fluid-e2e |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mainly addresses some typos and issues with log parameter printing that were discovered during code reading, with no changes to the code logic.
It is important to note that in the
github.com/go-logr/logrlibrary, the functiontakes a string and several key/value pairs as parameters. If the key/value fmt are not satisfied, this method will directly cause the program to exit, which is very serious and cannot be detected by go fmt.