Skip to content

refactor: Correct the development document - #4412

Merged
fluid-e2e-bot[bot] merged 1 commit into
fluid-cloudnative:masterfrom
wjp-cn:correct-development-document
Nov 22, 2024
Merged

refactor: Correct the development document#4412
fluid-e2e-bot[bot] merged 1 commit into
fluid-cloudnative:masterfrom
wjp-cn:correct-development-document

Conversation

@wjp-cn

@wjp-cn wjp-cn commented Nov 22, 2024

Copy link
Copy Markdown
Contributor

Ⅰ. Describe what this PR does

Correct the development document

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

There is an example of an operation command that is missing double quotation marks, causing the use of blocking

Ⅳ. Describe how to verify it

Verify through “make test”

Ⅴ. Special notes for reviews

@wjp-cn
refactor: Correct the development document
4144e71 
Signed-off-by: wjp <wjp_199502@163.com>
@fluid-e2e-bot

fluid-e2e-bot Bot commented Nov 22, 2024

Copy link
Copy Markdown

Hi @Wercurial. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud

sonarqubecloud Bot commented Nov 22, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cheyang
cheyang approved these changes Nov 22, 2024
View reviewed changes

@cheyang cheyang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot Bot added the lgtm label Nov 22, 2024
@fluid-e2e-bot

fluid-e2e-bot Bot commented Nov 22, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot
fluid-e2e-bot Bot merged commit 68540bf into fluid-cloudnative:master Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

Labels

approved lgtm needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wjp-cn @cheyang