Skip to content

feat: thinruntime support pod metadata - #5276

Merged
fluid-e2e-bot[bot] merged 9 commits into
fluid-cloudnative:masterfrom
TrafalgarZZZ:feat/thinruntime_support_pod_metadata
Oct 14, 2025
Merged

feat: thinruntime support pod metadata#5276
fluid-e2e-bot[bot] merged 9 commits into
fluid-cloudnative:masterfrom
TrafalgarZZZ:feat/thinruntime_support_pod_metadata

Conversation

@TrafalgarZZZ

Copy link
Copy Markdown
Member

Ⅰ. Describe what this PR does

  • Add podMetadata field in ThinRuntime and ThinRuntimeProfile
  • Populate podMetadata.labels and podMetadata.annotations to ThinRuntime FUSE pod's metadata

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ

Copy link
Copy Markdown
Member Author

/test fluid-e2e

@codecov

codecov Bot commented Oct 11, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.63780% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.97%. Comparing base (9f5904e) to head (ab4009f).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
pkg/ddc/thin/mock_utils.go 97.29% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5276      +/-   ##
==========================================
+ Coverage   56.71%   56.97%   +0.26%     
==========================================
  Files         440      441       +1     
  Lines       30369    30488     +119     
==========================================
+ Hits        17223    17372     +149     
+ Misses      11535    11506      -29     
+ Partials     1611     1610       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cheyang

cheyang commented Oct 11, 2025

Copy link
Copy Markdown
Collaborator

@TrafalgarZZZ Please run make update-api-doc to update the API doc.

Comment thread charts/thin/values.yaml
@@ -61,6 +61,8 @@ fuse:
image: ""
imageTag: ""
imagePullPolicy: IfNotPresent

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increment the helm chart version to track the change.

Signed-off-by: TrafalgarZZZ <trafalgarz@outlook.com>
Signed-off-by: TrafalgarZZZ <trafalgarz@outlook.com>
@sonarqubecloud

Copy link
Copy Markdown

@cheyang cheyang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot

fluid-e2e-bot Bot commented Oct 14, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot
fluid-e2e-bot Bot merged commit ea2351b into fluid-cloudnative:master Oct 14, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants