Skip to content

fix: mark Identify Customer Goals survey as translatable#7566

Merged
Dhruwang merged 3 commits into
formbricks:mainfrom
urbalazs:fix-survey-translation
Apr 17, 2026
Merged

fix: mark Identify Customer Goals survey as translatable#7566
Dhruwang merged 3 commits into
formbricks:mainfrom
urbalazs:fix-survey-translation

Conversation

@urbalazs
Copy link
Copy Markdown
Contributor

@urbalazs urbalazs commented Mar 23, 2026

What does this PR do?

This PR marks the headline and choices as translatable in Identify Customer Goals survey.

How should this be tested?

  • Select a GUI language different to English.
  • Create a survey from template Identify Customer Goals.

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: bfc80852-1d40-4129-afc3-96718ce92922

📥 Commits

Reviewing files that changed from the base of the PR and between 37f652c and 24c2216.

⛔ Files ignored due to path filters (15)
  • apps/web/i18n.lock is excluded by !**/*.lock
  • apps/web/locales/de-DE.json is excluded by !apps/web/locales/**
  • apps/web/locales/en-US.json is excluded by !apps/web/locales/**
  • apps/web/locales/es-ES.json is excluded by !apps/web/locales/**
  • apps/web/locales/fr-FR.json is excluded by !apps/web/locales/**
  • apps/web/locales/hu-HU.json is excluded by !apps/web/locales/**
  • apps/web/locales/ja-JP.json is excluded by !apps/web/locales/**
  • apps/web/locales/nl-NL.json is excluded by !apps/web/locales/**
  • apps/web/locales/pt-BR.json is excluded by !apps/web/locales/**
  • apps/web/locales/pt-PT.json is excluded by !apps/web/locales/**
  • apps/web/locales/ro-RO.json is excluded by !apps/web/locales/**
  • apps/web/locales/ru-RU.json is excluded by !apps/web/locales/**
  • apps/web/locales/sv-SE.json is excluded by !apps/web/locales/**
  • apps/web/locales/zh-Hans-CN.json is excluded by !apps/web/locales/**
  • apps/web/locales/zh-Hant-TW.json is excluded by !apps/web/locales/**
📒 Files selected for processing (1)
  • apps/web/app/lib/templates.ts

Walkthrough

The changes modify the identifyCustomerGoals function in apps/web/app/lib/templates.ts to replace hardcoded English text with internationalization (i18n) lookups. Specifically, the multiple-choice element's headline and all four choice options are now derived from i18n keys instead of static strings. The template structure and control flow remain unchanged, with only string references updated.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description covers the main changes and testing instructions, but the required 'pnpm build' and CLA signing checklist items are marked incomplete, which may prevent merge. Confirm whether 'pnpm build' was executed and verify CLA signing status if this is a first contribution to avoid merge blockers.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: marking the Identify Customer Goals survey as translatable, which aligns with the code modifications that replaced hardcoded English strings with i18n lookups.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Dhruwang Dhruwang mentioned this pull request Apr 17, 2026
Closed
12 tasks
Dhruwang
Dhruwang approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Dhruwang Dhruwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Looks good.

@Dhruwang Dhruwang enabled auto-merge April 17, 2026 09:41
@Dhruwang Dhruwang added this pull request to the merge queue Apr 17, 2026
Merged via the queue into formbricks:main with commit fc9ddb2 Apr 17, 2026
24 of 27 checks passed
@urbalazs urbalazs deleted the fix-survey-translation branch April 20, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dhruwang Dhruwang Dhruwang approved these changes

@jobenjada jobenjada Awaiting requested review from jobenjada

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@urbalazs @Dhruwang