Repository navigation
feat(subagents): Let listAgents show a child's parent and siblings - #2140
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 401f4e0. Configure here.
Contributor
|
1 screenshot change — 1 changed · 0 added · 0 removed Review screenshots in Frameshift
|
sentry-junior
Bot
force-pushed
the
feat/list-agent-relatives
branch
from
October 15, 2026 01:05
a675f5c to
c4b34e0
Compare
This was referenced Oct 15, 2026
dcramer
added a commit
that referenced
this pull request
Oct 15, 2026
Move both Frameshift steps from v0.1.0 (`b730732`) to v0.2.0 (`57ef8e4`). v0.2.0 ignores sub-pixel glyph drift (dcramer/frameshift#17). Chrome sometimes draws text a fraction of a pixel to one side between runs. v0.1.0 reported those screenshots as changed, even though they look the same. PR #2140 had 12 such false flags. Checks: - The `ci/` and `publish/workflow` action files did not change between the two versions, so the inputs and baseline artifacts stay the same. - v0.2.0 on the #2140 baseline and candidate images reports 0 changed instead of 12. Baseline images do not change. Frameshift checks this PR's screenshots with v0.2.0. Real changes still show up. <!-- junior-request-attribution:start --> via **David Cramer**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AC0B595QDZLL%3A1792026612.765249 --> -- [View Junior Session](https://junior-prod.sentry.dev/conversations/slack%3AC0B595QDZLL%3A1792026612.765249) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0B595QDZLL%3A1792026612.765249/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: David Cramer <david@sentry.io>
Member
|
need to rebase and deslop this, make sure its aligned w/ recent changes |
sentry-junior
Bot
force-pushed
the
feat/list-agent-relatives
branch
from
October 15, 2026 05:42
c4b34e0 to
e4a7c26
Compare
dcramer
approved these changes
Oct 15, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next step for the agent coordination tools in #2105.
listAgentscame only withspawnAgent. With the defaultlimits.maxAgentDepth: 0, a child agent never got it, so it could not see the work around it.Now every child run gets
listAgents. Each listed agent has arelation:self,parent,child, orsibling. A child sees its own task and state, its parent, and the other child agents of its parent. A root sees only its child agents, as before.The parent shows the Conversation execution status of the parent, with a failed Turn as
idle. It has no task.messageAgentstill sends only to"parent"or a direct child. Messages to siblings andprogresscome next in #2105.via David Cramer.
--
View Junior Session [Sentry]