Repository navigation
feat(memory): Link passive memories to the files they came from - #2483
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Project the Sandbox file that readFile, editFile, and writeFile name onto plugin run tool results as paths. Passive extraction stores those paths in a new junior_memory_file_refs table when a memory cites the tool result. This is the provenance half; recall by file comes later. Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
2 screenshot changes — 2 changed · 0 added · 0 removed Review screenshots in Frameshift
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype of file provenance for memory, adapted from Lore's
knowledge_file_refs. It is the first step toward showing related memories when the agent touches a file. Recall by file is not part of this PR.How it works
pathsfield to tool-result entries in the plugin run transcript. ForreadFile,editFile, andwriteFile, core takes the path from the matching tool call input and makes it relative to the Sandbox root (for examplerepos/junior/README.md).paths, the memory plugin writes those files to a newjunior_memory_file_refstable. A duplicate capture adds its files to the memory that already exists. Lore links a memory to every file the session touched; this links it only to the files its cited evidence came from, so the link is tighter.pathsbefore the transcript goes to the model.Open questions
repos/<name>checkout layout, not onowner/repo. Two repos with the same name share keys. We could key onowner/repoplus a repo-relative path, but then core needs the git remote while the run is still active.bash,grep, andfindFilesare not covered. Lore has a heuristic parser for paths in shell commands that we could port later.createMemorytool get no file links.via @BYK.
--
View Session [Sentry]