Repository navigation
feat(sveltekit): Emit low cardinality function spans - #24341
Merged
Merged
Conversation
Lms24
marked this pull request as ready for review
September 11, 2026 12:43
Lms24
requested review from
mydea and
nicohrubec
and removed request for
a team
September 11, 2026 12:43
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b9abc06. Configure here.
Contributor
size-limit report 📦
|
JPeer264
approved these changes
Sep 11, 2026
Lms24
enabled auto-merge (squash)
September 11, 2026 15:23
This was referenced Sep 16, 2026
3 tasks done
chargome
added a commit
that referenced
this pull request
Oct 12, 2026
The `url.path` attribute added in #24341 made the load wrappers read `event.url.pathname` outside `untrack`. SvelteKit took that as the load depending on the URL, so every wrapped load reran on each navigation. With auto-instrumentation on, that's every load in the app. The pathname is now read through `event.untrack`, the same way `getRouteId` already reads `route.id`. On SvelteKit 2 versions that don't have `untrack` yet, it calls the native `URL.prototype` getter instead. SvelteKit's tracking getter is an own property on `event.url`, so the native getter skips it. Fixes #25231 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusts span names of
functionspans from SvelteKit:name: 'load'and carry the route, as well as the function name on additional attributes