Repository navigation
Conversation
Contributor
size-limit report 📦Compared: 986b36a (PR test merge using develop at 5ef02e1) Against: a1162e3 (develop) · base run #65032
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 2 not successful, 10 successful. See the run.
Successful checks
|
logaretm
force-pushed
the
awad/runtime-tunnel-drop-framework-hooks
branch
2 times, most recently
from
November 2, 2026 21:29
80937ea to
05739c4
Compare
logaretm
force-pushed
the
awad/runtime-tunnel-drop-framework-hooks
branch
2 times, most recently
from
November 3, 2026 04:10
8290699 to
5070a1e
Compare
logaretm
force-pushed
the
awad/runtime-tunnel-drop-framework-hooks
branch
2 times, most recently
from
November 3, 2026 04:28
2df929e to
37ff5cc
Compare
logaretm
force-pushed
the
awad/runtime-tunnel-drop-framework-hooks
branch
from
November 3, 2026 04:42
37ff5cc to
d4ee2c6
Compare
logaretm
force-pushed
the
awad/runtime-tunnel-drop-framework-hooks
branch
from
November 3, 2026 04:45
d4ee2c6 to
df4b1de
Compare
logaretm
force-pushed
the
awad/runtime-tunnel-drop-framework-hooks
branch
4 times, most recently
from
November 3, 2026 05:17
f0a9f77 to
e9a696a
Compare
logaretm
marked this pull request as ready for review
November 3, 2026 05:19
logaretm
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
November 3, 2026 05:19
logaretm
force-pushed
the
awad/runtime-tunnel-drop-framework-hooks
branch
from
November 3, 2026 05:37
e9a696a to
93418ff
Compare
3 tasks done
The runtimes answer managed tunnel requests before any framework sees them, so the per-framework hooks in Astro, Nitro, Nuxt, React Router, Remix, SolidStart, SvelteKit and TanStack Start go. The frameworks only set the tunnel's base path. Astro now initializes the server SDK from the server entry in builds, which the late init in its middleware used to cover.
logaretm
force-pushed
the
awad/runtime-tunnel-drop-framework-hooks
branch
from
November 4, 2026 17:29
93418ff to
c8efc75
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c8efc75. Configure here.
| nitroApp.hooks.hook('error', captureErrorHook); | ||
| instrumentTasks(tasks); | ||
|
|
||
| // Nitro runs the app's `middleware/` before anything a module registers, so an auth middleware there would block |
There was a problem hiding this comment.
Serverless tunnel intercept was removed
High Severity
Removing the framework-level tunnel intercept leaves managed tunnel POSTs unanswered on serverless and fetch-based presets. Runtime hooks only wrap node:http Server.emit, Cloudflare withSentry, and Lambda, while Vercel, Netlify, and similar adapters invoke a listener or nitroApp.fetch and never hit those. Browser envelopes then fall through to the app instead of being forwarded.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit c8efc75. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this point, we handle the runtimes we support, so the previous framework-specific wiring is no longer needed.
This PR adjusts a couple of wiring for some safety around double inits in serverless environments, and cleans up most of the old code introduced in
11.10.Note for reviewers: if you are lacking context on this PR, check #25997