Repository navigation
ci: Retry failed integration and E2E tests once on PRs - #26112
Draft
sentry-junior[bot] wants to merge 2 commits into
Draft
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
Retries stay off for develop and other pushes, so flaky tests keep failing there and the weekly flaky test report keeps seeing them. Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
mydea
reviewed
Nov 4, 2026
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 3 not successful, 37 successful. See the run.
Successful checks
|
Contributor
size-limit report 📦Compared: e05a815 (PR test merge using develop at e4eff2c) Against: e4eff2c (develop) · base run #65029 ✅ Baseline matches: this diff contains only this PR's changes.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Flaky failures in the integration and E2E suites keep making people click "Re-run failed jobs" on their PRs. This change retries a failed test once, but only on
pull_requestruns, which we detect withGITHUB_EVENT_NAMEsobuild.ymlneeds no changes. Develop pushes, release branches, and scheduled and manual runs stay strict. That matters becausescripts/weekly-flaky-tests.mjsonly reads develop runs and only failed jobs. If retries ran there too, a test that passed on retry would leave the run green and disappear from the report.Covered: node, cloudflare, bun and deno (node-suites) via Vitest
retry; browser-integration-tests; E2E apps that usegetPlaywrightConfig; and the 5 E2E apps with their own Playwright config.How to review: Start with
getTestRetries()intest-utils/src/retries.ts; every config uses it. browser-integration-tests, deno-integration-tests and the 3*-send-to-sentryE2E apps didn't depend on@sentry-internal/test-utilsyet, so they get it as a new dev dependency. Vitest projects withextends: trueinherit the rootretry, so the bun projects are covered too. I checked this with a throwaway Vitest 4.1.11 project.Unsure about:
deno testsuites have no retry option, so they're not covered.beforeAll(e.g.describeWithDockerCompose) is not retried.merge_groupshould be added to the condition.--
View Session [Sentry]