Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: #17309 asks for one CDN script for micro frontends instead of
bundle.min.jsplus themultiplexedtransport.min.jsandmodulemetadata.min.jsaddons, and the thread settled on a single errors-only combination.bundle.mfe.min.jsis the errors-only bundle plusmakeMultiplexedTransportandmoduleMetadataIntegration. It adds about 650 bytes gzipped tobundle.min.js(size-limit: 32,838 vs 32,194 bytes), while the two addon scripts are about 2 KB gzipped and two extra requests.How to review: The entry is
packages/browser/src/index.bundle.mfe.ts, and the rest registers it the way #19020 registeredbundle.logs.metrics. The non-obvious part isgeneratePlugin.ts: forbundle_mfe*it no longer injects the two addon bundles, because they overwrite the same keys onwindow.Sentry, sotransport/multiplexedandintegrations/moduleMetadatawould pass even with both exports missing from the bundle. Locally, the browser unit tests and the full Chromium integration suite withPW_BUNDLE=bundle_mfeandbundle_mfe_minpass.Unsure about: The name
bundle.mfeis the one suggested in the issue, happy to rename.bundle_mfealso adds one job to the Playwright matrix, as #19020 did.Closes #17309