Repository navigation
Conversation
…ded on spans Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: With
enableOpenTelemetrySetup: true, OpenTelemetry instrumentation records errors throughspan.recordException(), which is a no-op on Sentry spans, so those errors never reach Sentry.spanExceptionsIntegration()captures them, linked to the span; it's opt-in because instrumentation also records errors the app handles, which is why #11221 removed the span processor version.How to review: Start with
packages/core/src/integrations/spanExceptions.tsand therecordExceptionhook both span classes now emit; the rest is re-exports. It skips exceptions recorded while tracing is suppressed and captures with tracing suppressed, so the SDK's own failing requests or I/O inbeforeSendcan't loop back into it.Unsure about:
handled: truemechanism, is the one kept.recordException(), so those are captured too, and a job that then fails is also reported asjob failed.suppressTracing()is honored, not OpenTelemetry's own suppression key, because core can't read the OpenTelemetry context.Closes #16015