fix: Update git2 dependency to include 'ssh' feature - #3009
Merged
Conversation
Added 'ssh' feature to git2 dependency in Cargo.toml
|
this pr did not commit the diff --git a/Cargo.lock b/Cargo.lock
index a699e228..8113e260 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2437,6 +2437,7 @@ checksum = "005d6ae6eac1912906073e069f7db60b1fa98e052a68227824afe3e3a1c59ca2"
dependencies = [
"cc",
"libc",
+ "libssh2-sys",
"libz-sys",
"openssl-sys",
"pkg-config",
@@ -2452,6 +2453,20 @@ dependencies = [
"libc",
]
+[[package]]
+name = "libssh2-sys"
+version = "0.3.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "c04141a07bb0c0bc461cb657808764de571702a59bc5c726c400ac9a7625e3ab"
+dependencies = [
+ "cc",
+ "libc",
+ "libz-sys",
+ "openssl-sys",
+ "pkg-config",
+ "vcpkg",
+]
+
[[package]]
name = "libz-sys"
version = "1.1.21" |
Contributor
Author
|
@youssefadly237 maybe you should write a test to ensure this does not happen again in the future |
|
A precommit? a CI check? What kind of tests? |
Contributor
Author
|
I would do a CI because pre-commits can be bypassed. |
|
Hey @extrawurst, Sorry for pinging, what do think of that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 'ssh' feature to git2 dependency in Cargo.toml
This Pull Request fixes #3008
I followed the checklist:
make checkwithout errors