[wgsl] Integrate the fragment_depth proposal into the spec - #6299
Conversation
|
Previews, as seen when this build job started (ebb7fe5): |
|
I think the next steps are committee review of the PR and CTS tests before this can land. |
mwyrzykowski
left a comment
There was a problem hiding this comment.
Seems fine though it would be nice to understand the benefit across backends. But no need to hold up moving forwards with this
minutes from WGSL committee meeting 2026-6-23
|
|
Re: Mike's request for an idea of benefits. I got a useful response from gemini by asking "what is conservative depth in graphics rendering". Excerpting from the reply: ##Common Use Cases
I* mpostors / Billboards: Rendering complex 3D assets (like distant trees or particles) on simple 2D cards while pushing the depth back to correctly match the shape of the real 3D asset.
In terms of prevalence/reach:
It should benefit at least these GPUs:
|
jimblandy
left a comment
There was a problem hiding this comment.
I'm sorry, I can't approve this yet:
Update the WGSL spec to include the fragment_depth proposal text. Closes gpuweb#5342
Co-authored-by: alan-baker <alanbaker@google.com>
jimblandy
left a comment
There was a problem hiding this comment.
Thank you for sorting out the "or equal" question!
I think it's clearer to talk about "returning" the value, since that's the act that matters. The change works fine; see my suggestion below. I think it'd be better not to talk about "writing" here at all; although the reader can figure out what was intended, "writes" are a thing described in the memory model, and that is definitely not what we're doing here.
However, the "write" vs "return" question is editorial; the PR is fine to land either way.
Co-authored-by: Jim Blandy <jimb@red-bean.com>
|
When we last discussed this in committee, I was the only person with remaining concerns, and they're addressed now. It's got a full list of approvals, so I think we can merge this without bringing it up in committee again. |
|
I need to write CTS tests I believe before this can land in the spec. I think that's the only missing piece at this point. |
Update the WGSL spec to include the fragment_depth proposal text.
Closes #5342