[editorial/bugfix] Dedup feature dependencies, fix missing auto-enablements - #6344
Open
kainino0x wants to merge 1 commit into
Open
[editorial/bugfix] Dedup feature dependencies, fix missing auto-enablements#6344kainino0x wants to merge 1 commit into
kainino0x wants to merge 1 commit into
Conversation
Contributor
|
Previews, as seen when this build job started (780004c): |
kainino0x
marked this pull request as ready for review
August 1, 2026 04:28
toji
approved these changes
Aug 5, 2026
| as defined by the |adapter|.{{adapter/[[default feature level]]}}. | ||
| 1. For each |feature| in |features|: | ||
| 1. [=set/Extend=] |features| with the set of features required (directly or indirectly) | ||
| by |feature|, as defined in [[#feature-dependencies]]. |
Member
There was a problem hiding this comment.
I'm happy that this is constructed in such a way that the implicitly enabled features show up explicitly in device.features. 👍
| Because of this, and to improve portability across devices and implementations, | ||
| applications should generally only request features that they may actually require. | ||
|
|
||
| <h5 id=gpufeaturename data-dfn-type=enum>`GPUFeatureName` |
Member
There was a problem hiding this comment.
Why on earth did we ever have this under GPUDeviceDescriptor?? This makes so much more sense! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this was defined separately in "Adapter Capability Guarantees", "a new device", and the "Feature Index".
This fixes a bunch of stuff that was missing:
texture-compression-bc-sliced-3d→texture-compression-bctexture-compression-astc-sliced-3d→texture-compression-astctexture-formats-tier2→texture-formats-tier1→rg11b10ufloat-renderableAlso moves the definition of
GPUFeatureNameto the "Optional Capabilities" section to be consistent with limits.