Repository navigation
ci: the release wheels link rust.native on Windows and carry musllinux's bundled libraries - #11
Merged
Merged
Conversation
…x's bundled libraries The Windows build sets PYO3_USE_RAW_DYLIB=0, as make build_native_windows does: raw-dylib linking does not resolve _PyDict_NewPresized. build_wheel.py takes hare_native.libs/ (libgcc_s on musllinux) from maturin's wheel along with the extension, which loads it from ../hare_native.libs. Signed-off-by: Vladislav Yaremenko <vlad.yaremenko.98@yandex.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release run of v0.9.0 failed on four wheel jobs:
_PyDict_NewPresizedunresolved at link time. The release build now setsPYO3_USE_RAW_DYLIB=0, asmake build_native_windowsdoes - raw-dylib linking doesn't resolve this private CPython symbol.rust.nativedoesn't import -libgcc_s-*.so.1is missing. maturin's repair bundles it intohare_native.libs/of its wheel, andbuild_wheel.pytook onlyrust/native*.sofrom there. It now takeshare_native.libs/too, and poetry packs it into the wheel at the same place, where the extension's run path finds it. The wheel check verifies the libraries got in.