Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
|
@lvwerra lmk what you think now. Also, where is the best place to document the viz function? in the evaluate docs directly, or via a README? |
|
If we plan on building out more visualizations, would it be worth committing to writing this module with the OO-interface for matplotlib? As far as I know it would make testing easier, and I think it would be more dev-friendly for composability + subclassing to extend functionality if folks have custom visualizations that they want to build out. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
One thing that's currently missing is documentation. I think it would be great to have some docs on this. E.g. create a new section |
|
Also, I don't understand the CircleCI errors 😬 |
lvwerra
left a comment
There was a problem hiding this comment.
Only minor things left to do. Can you use the following format for the docstrings:
https://github.com/huggingface/doc-builder#writing-source-documentation
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
|
The CI is green now :) I think there are just two more things left to do:
|
I've currently added the code from ComplexRadar() and it does work, but I can't figure out at what point it makes most sense to add the
invert_rangeflag@lvwerra would love your help!