Updates for release 3.5.0#175
Open
rlktradewright wants to merge 4 commits into
Open
Conversation
added 4 commits
February 8, 2018 17:16
...and use separate exit codes for the various error conditions.
If the IBController.bat script returned a non-zero ERRORLEVEL for any reason (including as a result of the java process being killed), then DisplayBannerAndLaunch.bat erroneously displayed a message that the logfile was already in use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been quite a few commits since the last release (3.4.0 on July 17 2017), and a new release is now worthwhile. While few of these commits are individually of much significance, collectively they are a substantial improvement over release 3.4.0.
The commits in this PR fix a problem introduced in commit e164d13 on Dec 11 2017, and make some worthwhile improvements to error handling in the IBController program and the Windows scripts. These, combined with the 22 since 3.4.0, form a good basis for a new release which I propose to designate 3.5.0.