This repository was archived by the owner on Jul 2, 2024. It is now read-only.
FIX: Carret position is invalid if editing text not at the end - #65
Merged
radimhalfar merged 2 commits intoMar 16, 2018
Merged
Conversation
- also added section for defining UI Elements and demonstrate usage of styles on it
radimhalfar
force-pushed
the
bugfix/carret_position_is_invalid_while_editing_text
branch
from
March 16, 2018 14:32
788a9ca to
5ce8e53
Compare
jakubpetrik
suggested changes
Mar 16, 2018
| NSString *text = self.text; | ||
| if (!text || !style) { | ||
|
|
||
| if (!text || !style) { |
| return; | ||
| } | ||
|
|
||
| UITextRange *range = self.selectedTextRange; |
|
|
||
| UITextRange *range = self.selectedTextRange; | ||
| [self setAttributedText:[style applyTo:text]]; | ||
| if (range) { |
| } | ||
| [self setAttributedText:[style applyTo:text]]; | ||
|
|
||
| UITextRange *range = self.selectedTextRange; |
Contributor
Author
There was a problem hiding this comment.
it is -- and all above too -- github shows that as invalid 🤷♂️
jakubpetrik
reviewed
Mar 16, 2018
|
|
||
| func didPickViewStyleDefinition(_ definition: ViewStyle.Definition) { | ||
| viewStyle = definition.viewStyle | ||
|
|
radimhalfar
force-pushed
the
bugfix/carret_position_is_invalid_while_editing_text
branch
from
March 16, 2018 15:04
4aa7ea5 to
5e7760d
Compare
jakubpetrik
approved these changes
Mar 16, 2018
radimhalfar
deleted the
bugfix/carret_position_is_invalid_while_editing_text
branch
April 27, 2018 08:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes BUG: Carret position is invalid if not editing at the end of the text #64