Fix out-of-bounds reads when parsing some malformed headers#9
Merged
Conversation
If a malformed address ended right after dtext, the original code would jump over the terminating null byte.
If a malformed address ended right after dtext, the original code would read past the terminating null byte.
strchr("BbQq", ...) was meant to check for these four characters, but
it returns true also for the null byte.
If a header ended with the "=?<charset>?" sequence, the original code
would read past the terminating null byte.
If a malformed header ended right after backslash, the original code would jump over the terminating null byte.
jstedfast
reviewed
Jul 31, 2017
| do { | ||
| while (is_dtext (*inptr)) | ||
| while (*inptr && is_dtext (*inptr)) | ||
| g_string_append_c (str, *inptr++); |
Owner
There was a problem hiding this comment.
I wonder if is_dtext() could be fixed to bail on '\0'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes multiple bugs that made GMime read past the terminating null byte.
Reproducer:
Found using American Fuzzy Lop.