Add refresh-on-profile-update as an optional param for browser pools - #194
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
hiroTamada
reviewed
Jul 9, 2026
hiroTamada
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
--refresh-on-profile-updateflag tokernel browser-pools createandkernel browser-pools update, plus bumpkernel-go-sdkto v0.75.0 (which provides theRefreshOnProfileUpdatefield on pool params and response types).The new flag flushes idle browser instances when the pool's profile is updated. It's forwarded to the SDK as an explicit optional field (guarded by
BoolFlag.Set) so omitting the flag on the command line leaves the SDK field unset and lets the server decide the default.Changes
cmd/browser_pools.go— AddRefreshOnProfileUpdate BoolFlagto bothBrowserPoolsCreateInputandBrowserPoolsUpdateInput, wire it throughCreate()/Update()toparams.RefreshOnProfileUpdate, register the--refresh-on-profile-updateCLI flag on both commands, and display the setting inkernel browser-pools getoutput.cmd/browser_pools_test.go— Add tests for:RefreshOnProfileUpdateset totrueRefreshOnProfileUpdateset tofalseProfileID+RefreshOnProfileUpdatecompose correctly when both are providedREADME.md— Document the new flag in the browser-pools reference section.go.mod/go.sum— Bumpkernel-go-sdkfrom v0.72.0 to v0.75.0.