Add iOS SDK configuration plist for Flutter identification#46
Add iOS SDK configuration plist for Flutter identification#46
Conversation
| s.author = { 'Klaviyo' => 'support@klaviyo.com' } | ||
| s.source = { :path => '.' } | ||
| s.source_files = 'Classes/**/*' | ||
| s.resources = ['klaviyo-sdk-configuration.plist'] |
There was a problem hiding this comment.
Inconsistent indentation on s.resources line
Low Severity
The s.resources line uses 2-space indentation while all other spec attribute lines (e.g. s.source_files, s.dependency) use 4-space indentation. This breaks the visual consistency of the podspec file.
There was a problem hiding this comment.
this is just not accurate 🫠
a75c925 to
a767dc4
Compare
ios/klaviyo-sdk-configuration.plist
Outdated
| <key>klaviyo_sdk_name</key> | ||
| <string>flutter</string> | ||
| <key>klaviyo_sdk_version</key> | ||
| <string>1.0.0</string> |
There was a problem hiding this comment.
could we change this to 0.1.0-alpha.1?
There was a problem hiding this comment.
Fixed. I also did two things to ensure this value is kept in sync:
- I added a pre-commit hook that automatically updates this value to match the pubspec.yaml whenever that file changes.
- I added a Github workflow that validates that this plist value is in sync with the pubspec.yaml value.
There was a problem hiding this comment.
Nice - I also added a 'bump version' script. I have it modify a plist but mind running it now that it's merged to see if it works?
dan-peluso
left a comment
There was a problem hiding this comment.
probably want some ios eyes, and def change that version but otherwise lgtm
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
a767dc4 to
b68f811
Compare
b68f811 to
90ae295
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
46827ff to
4cd5082
Compare
Summary
klaviyo-sdk-configuration.plistto the iOS plugin so the native Swift SDK identifies outgoing requests as coming from the Flutter SDKs.resourcesto the podspec so the plist gets bundled into the host appOnce the companion Swift SDK change is released, this will cause:
klaviyo-flutter/1.0.0instead ofklaviyo-swift/5.2.0flutterasklaviyo_sdkand1.0.0assdk_versionflutterforSDK Nameand1.0.0forSDK VersionDependencies
KlaviyoSwiftdependency version pin in the podspec will need to be bumped to whichever Swift SDK release includes that changeTest plan
klaviyo-flutter/1.0.0in the User-Agentflutter/1.0.0flutter/1.0.0Related issues
🤖 Generated with Claude Code