Run nginx as a worker#11334
Conversation
| nginx: | ||
| group: 'webserver' | ||
| supervisord: | ||
| command: 'nginx -c %(ENV_KONFIG_PROJECTROOT)s/nginx.conf' |
There was a problem hiding this comment.
s/nginx.conf/deployment/generated_files/nginx.conf
also could you remove the fs.writeFileSync "./nginx.conf", KONFIG.nginxConf line from configure? any idea why we are duplicating it?
There was a problem hiding this comment.
could you also change the "stopsignal" to QUIT for supervisord conf of this worker? we will make sure that nginx is restarted/stopped gracefully.
There was a problem hiding this comment.
I don't recall. I suppose it was just to have a shorter path.
Stop signal is a good catch. Also, that reminded me an old observation. I think supervisorctl shutdown kills the subprocesses because it is much faster than supervisorctl stop all. I'll dig into it.
There was a problem hiding this comment.
I'll remove redundant configuration output files in a separate pull request.
|
|
||
|
|
||
| "/opt/elasticbeanstalk/hooks/appdeploy/post/070_configure_supervisord.sh": | ||
| "/opt/elasticbeanstalk/hooks/appdeploy/post/070_configure_nginx.sh": |
There was a problem hiding this comment.
old files might stay during updates if machine is not get recycled
There was a problem hiding this comment.
I should add current file names to overrides configuration.
cihangir
left a comment
There was a problem hiding this comment.
better to have stopsignal changed to QUIT
Signed-off-by: Sonmez Kartal <sonmez@koding.com>
Signed-off-by: Sonmez Kartal <sonmez@koding.com>
Signed-off-by: Sonmez Kartal <sonmez@koding.com>
|
Updated. |
| startsecs : 10 | ||
| startretries : 5 | ||
| stopsignal : 'TERM' | ||
| stopsignal : options.stopsignal or 'TERM' |
There was a problem hiding this comment.
this is not needed, line 65 already handles those
Signed-off-by: Sonmez Kartal sonmez@koding.com