Conversation
NewlineStreamIO.read() stopped as soon as it had accumulated `size` bytes (StreamServer._handle_client always calls read(4096)), even if it hadn't found the real \n delimiter yet. Any IPC-transport JSON-RPC message over ~4KB was silently truncated mid-token, producing a parse-error response with id: null that a waiting client can never match to its request -- and left the unconsumed remainder corrupting framing for subsequent messages on the same persistent connection. Now reads until the delimiter is actually found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewlineStreamIO.read() stopped as soon as it had accumulated
sizebytes (StreamServer._handle_client always calls read(4096)), even if it hadn't found the real \n delimiter yet. Any IPC-transport JSON-RPC message over ~4KB was silently truncated mid-token, producing a parse-error response with id: null that a waiting client can never match to its request -- and left the unconsumed remainder corrupting framing for subsequent messages on the same persistent connection.Now reads until the delimiter is actually found.