SHA256 improvements#6965
Merged
Merged
Conversation
As users begin to specify the object ID types, provide an internal mechanism to determine whether the type is valid / supported or not.
Instead of simply taking the oid type, future-proof our index opening and creation functionality by taking an options structure.
Object ID type should be an option within the options structure; move it there.
odb wrapping
The `wrap_odb` function doesn't need to know the OID types in the object database; the object database already knows the type.
Future-proof the SHA256-ification of `git_repository_new` by taking an options structure instead of an oid type.
Instead of making the commit and dump functions take individual options structures; provide the options structure to the writer creator. This allows us to add additional information (like OID type) during generation.
Provide an options structure to commit graph opening. This allows us to specify information (like OID type) during opening.
Provide an options structure to MIDX writing. This allows us to specify information (like OID type) during writer creation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A handful of improvements to the SHA256 support - especially future-proofing the options structures.