Skip to content

fix: swap end for flex-end in browser/hover.css - #224102

Merged
Aiday Marlen Kyzy (aiday-mar) merged 9 commits into
microsoft:mainfrom
repraze:patch-1
Sep 11, 2024
Merged

fix: swap end for flex-end in browser/hover.css#224102
Aiday Marlen Kyzy (aiday-mar) merged 9 commits into
microsoft:mainfrom
repraze:patch-1

Conversation

@repraze

Copy link
Copy Markdown
Contributor

Fixes incorect justify-content value set in #210472.

This resolves an autoprefixer warning while bundling with monaco-editor.

autoprefixer: end value has mixed support, consider using flex-end instead

Fixes justify-content value set in microsoft#210472 .

This resolves an autoprefixer warning while bundling with monaco-editor.

``` txt
autoprefixer: end value has mixed support, consider using flex-end instead
```
@repraze

Copy link
Copy Markdown
Contributor Author

Any issues merging this?

@aiday-mar

Copy link
Copy Markdown
Contributor

Hi thank you for the PR, this PR looks good, sorry. I think I previously approved it? Not sure what happened.

@aiday-mar

Aiday Marlen Kyzy (aiday-mar) commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

I will ask someone else to review it too. I think the PR did not receive enough approvals to be merged.

@vs-code-engineering vs-code-engineering Bot added this to the September 2024 milestone Sep 11, 2024
@aiday-mar
Aiday Marlen Kyzy (aiday-mar) merged commit 17d912d into microsoft:main Sep 11, 2024
@repraze

Copy link
Copy Markdown
Contributor Author

Thanks! I'll be glad to see this warning gone.

@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants