Fix to be the same specification as --exclude of rsync command (about function which is an alternative to rsync command) - #244
Merged
Conversation
The rsync command `--exclude` can remove` lib/main.js` in `*main*`. _fileCopy did not satisfy the specification, so I modified it
The rsync command `--exclude` can remove` lib/main.js` in `*main*`.
- To make it easy to understand what file failed - Using `assert.include`
DeviaVir
self-requested a review
April 25, 2017 14:38
DeviaVir
approved these changes
Apr 25, 2017
DeviaVir
left a comment
Collaborator
There was a problem hiding this comment.
Curious how this plays out, please continue 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
（After checking the operation a bit more in my environment, I will replace it with the
_fileCopyfunction from the_rsyncfunction.）In order to make it easy to understand where test failed, I changed the way I write the test. (The meaning of the test has not changed.)