Skip to content

Fix inspect types - #1093

Merged
sobolevn merged 1 commit into
msgspec:mainfrom
sobolevn:fix-inspect-types
Jun 21, 2026
Merged

Fix inspect types#1093
sobolevn merged 1 commit into
msgspec:mainfrom
sobolevn:fix-inspect-types

Conversation

@sobolevn

@sobolevn sobolevn commented Jun 21, 2026

Copy link
Copy Markdown
Member
  • types.UnionType is always defined
  • typing_Type is not needed anymore

@codspeed-hq

codspeed-hq Bot commented Jun 21, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚡ 6 improved benchmarks
❌ 6 regressed benchmarks
✅ 262 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation test_encode_type[amd-msgpack-decimal] 7.5 ms 7.6 ms -1.69%
❌ Simulation test_decode_type[amd-json-tuple] 41.8 µs 42.5 µs -1.58%
❌ Simulation test_encode_type[amd-json-set] 1.2 ms 1.2 ms -1.38%
❌ Simulation test_encode_type[amd-json-frozenset] 1.2 ms 1.2 ms -1.28%
❌ Simulation test_encode_type[amd-json-time] 10.7 ms 10.8 ms -1.16%
❌ Simulation test_copy[arm] 17.4 µs 17.6 µs -1.02%
⚡ Simulation test_encode_type[arm-msgpack-bytearray] 25.5 µs 24.2 µs +5.41%
⚡ Simulation test_encode_type[arm-msgpack-bytes] 25.6 µs 24.3 µs +5.28%
⚡ Simulation test_encode_type[arm-json-tuple] 11.9 µs 11.7 µs +1.5%
⚡ Simulation test_encode_type[arm-json-bytearray] 78.7 µs 77.7 µs +1.35%
⚡ Simulation test_encode_type[arm-json-memoryview] 78.6 µs 77.7 µs +1.19%
⚡ Simulation test_copy_complex[amd] 17.8 µs 17.6 µs +1.07%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing sobolevn:fix-inspect-types (765f581) with main (a1b31e7)

Open in CodSpeed

@sobolevn
sobolevn added this pull request to the merge queue Jun 21, 2026
Merged via the queue into msgspec:main with commit e18fab4 Jun 21, 2026
27 of 29 checks passed
@sobolevn
sobolevn deleted the fix-inspect-types branch June 21, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@provinzkraut provinzkraut provinzkraut approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn @provinzkraut