[WIP] try to support more wheels - #1149
Conversation
Merging this PR will improve performance by 10.32%
Performance Changes
Tip Curious why this is faster? Comment Comparing 
Footnotes
|
sobolevn
left a comment
There was a problem hiding this comment.
I think that x86_64 macos would be the only reasonable thing to support?
I am also not a fan of the CI speed. All jobs take 10+ minutes to test these platforms. Which is a long time :(
| --output-dir wheelhouse | ||
| "${PACKAGE_DIR}" | ||
| - name: Set up QEMU | ||
| if: runner.os == 'Linux' && contains(fromJSON('["ppc64le","s390x","armv7l"]'), matrix.wheel.archs) |
There was a problem hiding this comment.
Do we really need these platforms? There was 1 real user request for these platforms: #788
I am asking, because this is not free for us:
- We have to maintain all the build infra
- We have to run CI for this regularly
I think that msgspec can be compiled locally quite easily and quite efficently. So, proving wheels is not 100% required for it to work.
Moreover, there's not much platform specific code in msgspec for us to test it heavily.
There was a problem hiding this comment.
Yes, this will increase the CI time, but for people who use these targets, installing the wheel will be much faster than compiling it on the spot
There was a problem hiding this comment.
I guess we can compile manylinux and musslinux on different GitHub Runners
The diff is large because of:
actions-up --yes --min-age 0I'll revert these changes later