Speedup struct decoding - #119
Merged
Merged
Conversation
This further optimizes the decoding of Struct types by rearranging the field lookup loop a bit to avoid `%` operations. This optimization is most effective on gcc, resulting in a 20% speedup in decode time. Clang already did most of this optimization automatically. With this change, on gcc `bench.py` decreases from ~700 us to ~550 us for json decoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This further optimizes the decoding of Struct types by rearranging the
field lookup loop a bit to avoid
%operations. This optimizationis most effective on gcc, resulting in a 20% speedup in decode time.
Clang already did most of this optimization automatically. With this
change, on gcc
bench.pydecreases from ~700 us to ~550 us for jsondecoding.