Use dict str cache for msgpack decoder - #121
Merged
Merged
Conversation
Previously we added a cache for short ascii string keys when decoding dicts using JSON. We now expand this optimization to the msgpack decoder as well.
Member
Author
|
With this change, the standard twitter.json dataset loads ~30% faster when using the untyped decoder. We still recommend using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we added a cache for short ascii string keys when decoding
dicts using JSON. We now expand this optimization to the msgpack decoder
as well.