Don't accidentally include C source in built whl - #130
Merged
Conversation
The `include_package_data=True` flag was set (I think this was a copy-paste from an example for distributing `.pyi` files in the package). This option automatically includes all files in the source tree in the built wheel as package data (including the original C source). Since we alreay manually set `package_data`, the boolean flag is unnecessary, and the C source adds a (comparatively) non-negligible amount of data to the the built `whl`. No need to set this flag, and removing it decreases the package size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
include_package_data=Trueflag was set (I think this was acopy-paste from an example for distributing
.pyifiles in thepackage). This option automatically includes all files in the source
tree in the built wheel as package data (including the original C
source). Since we alreay manually set
package_data, the boolean flagis unnecessary, and the C source adds a (comparatively) non-negligible
amount of data to the the built
whl. No need to set this flag, andremoving it decreases the package size.