Add weakref support to Struct types - #131
Merged
Merged
Conversation
This adds a new `weakref` config option for structs. If `True`, instances of the struct type will support weakrefs. Defaults to False. This also fixes a few subtle (and unlikely) bugs in the `Struct_dealloc` implementation: - Fixes a bug when deallocating long chains of Struct instances, which requires trashcan support. Previously the freelist interactions were done outside of the TRASHCAN macros, which was incorrect. - Fixes a bug where `Struct` types with a `__del__` method and GC support interacted poorly with the freelist, potentially causing reused instances to fail to run their `__del__` method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
weakrefconfig option for structs. IfTrue, instances of the struct type will support weakrefs. Defaults to False.This was requested by a user for quickle (jcrist/quickle#63), which isn't actively maintained, but is the predecessor for
msgspec. It was easy enough to add, and uncovered a few subtle bugs (fixed here):Structtypes with a__del__method and GC support interacted poorly with the freelist, potentially causing reused instances to fail to run their__del__method.