breaking: Encode/decode all enums by value. - #211
Merged
Merged
Conversation
Previously integer enums encoded/decoded by their integer *values*, while all other enums encoded/decoded by their string *names*. This PR changes things so that all enums encode/decode by their values (string and integer values only supported for now). This is a *breaking change*. Many other tools in the python ecosystem support encoding enums as their values by default (`orjson`, `pydantic`, `cattrs`, `json`), but no tool AFAICT supports encoding as their names by default. The purpose of this change is to better match the rest of the Python ecosystem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously integer enums encoded/decoded by their integer values,
while all other enums encoded/decoded by their string names. This PR
changes things so that all enums encode/decode by their values (string
and integer values only supported for now).
This is a breaking change
Before this PR:
After this PR:
Many other tools in the python ecosystem support encoding enums as their
values by default (
orjson,pydantic,cattrs,json), but no toolAFAICT supports encoding as their names by default. The purpose of this
change is to better match the rest of the Python ecosystem.
Fixes #209.