Fix bug in JSON base64 encoding - #217
Merged
Merged
Conversation
Previously there was a bug in the base64 encoding implementation used by `msgspec.json` for encoding `bytes`/`bytearray`/`memoryview` objects. This bug only appeared for bytes with values outside the range 0 <= x <= 127, which weren't caught by the existing tests. To remedy this we: - fix the bug - augment the existing test suite to cover this situation - add some fuzz testing for the base64 encoding code
jcrist
force-pushed
the
fix-json-encode-binary
branch
from
November 29, 2022 04:48
1332f3e to
8b62a73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously there was a bug in the base64 encoding implementation used by
msgspec.jsonfor encodingbytes/bytearray/memoryviewobjects. This bug only appeared for bytes with values outside the range 0 <= x <= 127, which weren't caught by the existing tests.To remedy this we:
Fixes #215.