Support decoding JSON from a str object - #229
Merged
Merged
Conversation
This adds support for decoding JSON from `str` objects, rather than just
`bytes` (or bytes-like) objects.
For peak performance it's still recommended to decode from a bytes-like
object, but native support for decoding from str types is faster than
forcing the user to call `str_message.encode("utf-8")` themselves.
This also adds support for formatting str JSON messages using
`msgspec.json.format`. If a str is passed in the return type is a str,
otherwise the return type is `bytes`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for decoding JSON from
strobjects, rather than justbytes(or bytes-like) objects.For peak performance it's still recommended to decode from a bytes-like object, but native support for decoding from str types is faster and more ergonomic than forcing the user to call
str_message.encode("utf-8")themselves.This also adds support for formatting str JSON messages using
msgspec.json.format. If a str is passed in the return type is a str, otherwise the return type isbytes.