Wrap errors in dataclass/attrs post-init methods - #472
Merged
Conversation
When decoding/converting to a dataclass/attrs type with a `__post_init__`/`__attrs_post_init__` method, we now wrap all `ValueError`/`TypeError` exceptions in a `ValidationError`. This mirrors the behavior used in the new `Struct.__post_init__` support, and helps provide more uniform error handling support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When decoding/converting to a dataclass/attrs type with a
__post_init__/__attrs_post_init__method, we now wrap allValueError/TypeErrorexceptions in aValidationError. This mirrors the behavior used in the newStruct.__post_init__support, and helps provide more uniform error handling support.