Assorted improvements - #60
Merged
Merged
Conversation
While I like "immutable" better, `frozen` is used by dataclasses/attrs/pydantic, and is a hardcoded parameter name in the new "dataclass_transform" for pyright. Better to stick to convention.
- Add exception types - Add `__version__` string - Move `_core.pyi` to `__init__.pyi` to better keep `_core` an implementation detail.
Uses `__dataclass_transform__` for better pyright integration. Still need a mypy plugin to catch `__init__` errors in mypy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
immutable->frozenfor better compatibility with other dataclass-like classes__dataclass_transform__to catch more code errors in pyright.