Speedup decoding of Enum types - #69
Merged
Merged
Conversation
This optimizes the decoding of Enums, following the same pattern recently implemented for `IntEnum` types. A custom hashtable object is generated once per Enum object and stored on the class as the `__msgspec_lookup__` attribute. The hashtable maps each enum name to its value, and allows us to lookup the enum values without allocating a temporary string object and using it to lookup the enum value. Using this method, I get a 10x speedup on decoding enums. This implementation will also be used in a follow-up PR for implementing decoding of `Literal` string types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This optimizes the decoding of Enums, following the same pattern
recently implemented for
IntEnumtypes. A custom hashtable object isgenerated once per Enum object and stored on the class as the
__msgspec_lookup__attribute. The hashtable maps each enum name to itsvalue, and allows us to lookup the enum values without allocating a
temporary string object and using it to lookup the enum value.
Using this method, I get a 10x speedup on decoding enums. This
implementation will also be used in a follow-up PR for implementing
decoding of
Literalstring types.