Skip to content

Relax all getrefcount tests to allow lower numbers #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofek merged 1 commit into from
Oct 20, 2025
Merged

Relax all getrefcount tests to allow lower numbers #854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions tests/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1370,14 +1370,14 @@ class Ex(Struct, Generic[T]):
dec = proto.Decoder(typ)
info = typ.__msgspec_cache__
assert info is not None
assert sys.getrefcount(info) == 4 # info + attr + decoder + func call
assert sys.getrefcount(info) <= 4 # info + attr + decoder + func call
dec2 = proto.Decoder(typ)
assert typ.__msgspec_cache__ is info
assert sys.getrefcount(info) == 5
assert sys.getrefcount(info) <= 5

del dec
del dec2
assert sys.getrefcount(info) == 3
assert sys.getrefcount(info) <= 3

def test_generic_struct_invalid_types_not_cached(self, proto):
class Ex(Struct, Generic[T]):
Expand Down Expand Up @@ -1545,7 +1545,7 @@ class Ex2(Struct, array_like=array_like, tag=True):
res = proto.decode(buf, type=typ)
assert res == msg
assert count == 2 # 1 for Ex(), 1 for decode
assert sys.getrefcount(singleton) == 2 # 1 for ref, 1 for call
assert sys.getrefcount(singleton) <= 2 # 1 for ref, 1 for call

@pytest.mark.parametrize("array_like", [False, True])
@pytest.mark.parametrize("union", [False, True])
Expand Down Expand Up @@ -1606,14 +1606,14 @@ class Ex(Generic[T]):
dec = proto.Decoder(typ)
info = typ.__msgspec_cache__
assert info is not None
assert sys.getrefcount(info) == 4 # info + attr + decoder + func call
assert sys.getrefcount(info) <= 4 # info + attr + decoder + func call
dec2 = proto.Decoder(typ)
assert typ.__msgspec_cache__ is info
assert sys.getrefcount(info) == 5
assert sys.getrefcount(info) <= 5

del dec
del dec2
assert sys.getrefcount(info) == 3
assert sys.getrefcount(info) <= 3

def test_generic_invalid_types_not_cached(self, decorator, proto):
@decorator
Expand Down Expand Up @@ -2179,14 +2179,14 @@ class Ex(TypedDict, Generic[T]):
dec = proto.Decoder(typ)
info = typ.__msgspec_cache__
assert info is not None
assert sys.getrefcount(info) == 4 # info + attr + decoder + func call
assert sys.getrefcount(info) <= 4 # info + attr + decoder + func call
dec2 = proto.Decoder(typ)
assert typ.__msgspec_cache__ is info
assert sys.getrefcount(info) == 5
assert sys.getrefcount(info) <= 5

del dec
del dec2
assert sys.getrefcount(info) == 3
assert sys.getrefcount(info) <= 3

def test_generic_typeddict_invalid_types_not_cached(self, proto):
TypedDict = pytest.importorskip("typing_extensions").TypedDict
Expand Down Expand Up @@ -2398,14 +2398,14 @@ class Ex(NamedTuple, Generic[T]):
dec = proto.Decoder(typ)
info = typ.__msgspec_cache__
assert info is not None
assert sys.getrefcount(info) == 4 # info + attr + decoder + func call
assert sys.getrefcount(info) <= 4 # info + attr + decoder + func call
dec2 = proto.Decoder(typ)
assert typ.__msgspec_cache__ is info
assert sys.getrefcount(info) == 5
assert sys.getrefcount(info) <= 5

del dec
del dec2
assert sys.getrefcount(info) == 3
assert sys.getrefcount(info) <= 3

def test_generic_namedtuple_invalid_types_not_cached(self, proto):
NamedTuple = pytest.importorskip("typing_extensions").NamedTuple
Expand Down
18 changes: 9 additions & 9 deletions tests/test_convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ class Custom:
x = Custom()
res = convert(x, Any)
assert res is x
assert sys.getrefcount(x) == 3 # x + res + 1
assert sys.getrefcount(x) <= 3 # x + res + 1

def test_custom_input_type_works_with_custom(self):
class Custom:
Expand All @@ -229,7 +229,7 @@ class Custom:
x = Custom()
res = convert(x, Custom)
assert res is x
assert sys.getrefcount(x) == 3 # x + res + 1
assert sys.getrefcount(x) <= 3 # x + res + 1

def test_custom_input_type_works_with_dec_hook(self):
class Custom:
Expand All @@ -247,8 +247,8 @@ def dec_hook(typ, x):
x = Custom()
res = convert(x, Custom2, dec_hook=dec_hook)
assert isinstance(res, Custom2)
assert sys.getrefcount(res) == 2 # res + 1
assert sys.getrefcount(x) == 2 # x + 1
assert sys.getrefcount(res) <= 2 # res + 1
assert sys.getrefcount(x) <= 2 # x + 1

def test_unsupported_output_type(self):
with pytest.raises(TypeError, match="more than one array-like"):
Expand Down Expand Up @@ -397,7 +397,7 @@ class MyInt(int):
x = MyInt(100)
sol = convert(x, MyInt)
assert sol is x
assert sys.getrefcount(x) == 3 # x + sol + 1
assert sys.getrefcount(x) <= 3 # x + sol + 1


class TestFloat:
Expand Down Expand Up @@ -535,10 +535,10 @@ class MyBytes(bytes):

del sol

assert sys.getrefcount(msg) == 2 # msg + 1
assert sys.getrefcount(msg) <= 2 # msg + 1
sol = convert(msg, MyBytes)
assert sol is msg
assert sys.getrefcount(msg) == 3 # msg + sol + 1
assert sys.getrefcount(msg) <= 3 # msg + sol + 1


class TestDateTime:
Expand Down Expand Up @@ -828,7 +828,7 @@ class Ex(enum.IntEnum):

msg = MyInt(1)
assert convert(msg, Ex) is Ex.x
assert sys.getrefcount(msg) == 2 # msg + 1
assert sys.getrefcount(msg) <= 2 # msg + 1
assert convert(MyInt(2), Ex) is Ex.y

def test_enum_missing(self):
Expand Down Expand Up @@ -2223,7 +2223,7 @@ class Ex2(Struct, array_like=array_like, tag=True):
res = convert(msg, type=typ, from_attributes=from_attributes)
assert type(res) is Ex
assert called
assert sys.getrefcount(singleton) == 2 # 1 for ref, 1 for call
assert sys.getrefcount(singleton) <= 2 # 1 for ref, 1 for call

@pytest.mark.parametrize("union", [False, True])
@pytest.mark.parametrize("exc_class", [ValueError, TypeError, OSError])
Expand Down
4 changes: 2 additions & 2 deletions tests/test_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,7 @@ def test_decode_timezone_cache(self):
tz2 = msgspec.json.decode(msg, type=datetime.datetime).tzinfo
assert tz is tz2
del tz2
assert sys.getrefcount(tz) == 3 # 1 tz, 1 cache, 1 func call
assert sys.getrefcount(tz) <= 3 # 1 tz, 1 cache, 1 func call
for _ in range(10):
gc.collect() # cache is cleared every 10 full collections

Expand Down Expand Up @@ -2293,7 +2293,7 @@ def test_decode_struct(self):
assert x == Person("harry", "potter", 13, False)

# one for struct, one for output of getattr, and one for getrefcount
assert sys.getrefcount(x.first) == 3
assert sys.getrefcount(x.first) <= 3

with pytest.raises(
msgspec.ValidationError, match="Expected `object`, got `int`"
Expand Down
10 changes: 5 additions & 5 deletions tests/test_msgpack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,13 +685,13 @@ def test_decode_memoryview_zerocopy(self, input_type):
assert bytes(res) == b"abcde"
assert len(res) == 5
if input_type is memoryview:
assert sys.getrefcount(ref) == 3
assert sys.getrefcount(ref) <= 3
del msg
assert sys.getrefcount(ref) == 3
assert sys.getrefcount(ref) <= 3
del res
assert sys.getrefcount(ref) == 2
assert sys.getrefcount(ref) <= 2
elif input_type is bytes:
assert sys.getrefcount(msg) == 3
assert sys.getrefcount(msg) <= 3

def test_datetime_aware_ext(self):
dec = msgspec.msgpack.Decoder(datetime.datetime)
Expand Down Expand Up @@ -816,7 +816,7 @@ def test_vartuple_lengths(self, size):
res = dec.decode(enc.encode(x))
assert res == x
if res:
assert sys.getrefcount(res[0]) == 3 # 1 tuple, 1 index, 1 func call
assert sys.getrefcount(res[0]) <= 3 # 1 tuple, 1 index, 1 func call

@pytest.mark.parametrize("typ", [tuple, Tuple, Tuple[Any, ...]])
def test_vartuple_any(self, typ):
Expand Down
10 changes: 5 additions & 5 deletions tests/test_struct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,16 +931,16 @@ class Test(Struct):
data = [1, 2, 3]

t = Test(data)
assert sys.getrefcount(data) == 3
assert sys.getrefcount(data) <= 3

repr(t)
assert sys.getrefcount(data) == 3
assert sys.getrefcount(data) <= 3

t2 = t.__copy__()
assert sys.getrefcount(data) == 4
assert sys.getrefcount(data) <= 4

assert t == t2
assert sys.getrefcount(data) == 4
assert sys.getrefcount(data) <= 4


def test_struct_gc_not_added_if_not_needed():
Expand Down Expand Up @@ -2581,7 +2581,7 @@ def __post_init__(self):
Ex(1)
assert called
# Return value is decref'd
assert sys.getrefcount(singleton) == 2 # 1 for ref, 1 for call
assert sys.getrefcount(singleton) <= 2 # 1 for ref, 1 for call

def test_post_init_errors(self):
class Ex(Struct):
Expand Down