Change chrome icons#49
Closed
arnissolle wants to merge 5 commits into
Closed
Conversation
added 5 commits
April 9, 2016 15:46
Added i18n compatibility + restructuring the manifest.json file
English and French locales added
Owner
|
Since this is not an official GitHub extension, we can not use octocat as the logo. |
Author
|
Oh, okay I see ;) |
Owner
|
Ah those seem good, sorry I didn't read the files changed given the description. If you can open another PR for i18n bits minus the spacing changes that'd be great! 🙇 |
Author
|
I was AFK for a while, sorry! |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I prefer the old octocat icons for github-gmail