Performance Fixes - #65
Open
kelchy wants to merge 16 commits into
Open
Conversation
atesgoral
reviewed
May 9, 2018
|
|
||
| var decodeAvpHeader = function(buffer, start) { | ||
| var avp = {}; | ||
| if (buffer.length - start - DIAMETER_MESSAGE_AVP_CODE < 4) return undefined; |
Member
There was a problem hiding this comment.
I'd suggest returning null instead of undefined when the contract for a function is to return an object. null can be viewed as having an "invalid object" meaning.
Author
There was a problem hiding this comment.
good idea, i'll update the PR.
also found more issues
proxiable bit fix
Added support for sctp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when there is a parsing error (i.e. unknown dictionary entry)
the buffer will not be spliced because of the try catch hence ending up in infinite loop
seen this couple of times when under heavy load