Skip to content

doc: simplify text in pull-requests.md #30458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 9 commits into from
Nov 15, 2019
Merged

doc: simplify text in pull-requests.md #30458

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0e964a7
doc, console: remove non-existant methods from docs
SimonSchick Nov 10, 2019
5bd6f51
doc: add lookup to http.request() options
lpinca Nov 10, 2019
31ea341
tools: update tzdata to 2019c
albertyw Nov 10, 2019
dc7b5fc
stream: add writableCorked to Duplex
addaleax Nov 13, 2019
f3ea4e9
http: outgoing cork
ronag Aug 8, 2019
78dbe74
crypto: fix key requirements in asymmetric cipher
tniessen Nov 4, 2019
ed40123
doc: remove "maintenance is supported by" text in BUILDING.md
Trott Nov 12, 2019
c71b89e
doc: remove "multiple variants" from BUILDING.md
Trott Nov 12, 2019
794d8be
doc: simplify text in pull-requests.md
Trott Nov 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
stream: add writableCorked to Duplex 
PR-URL: #29053
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
@addaleax
addaleax committed Nov 13, 2019
commit dc7b5fca3ae2bcf74fdba8ad47ea499dbd2f0fd4
10 changes: 10 additions & 0 deletions lib/_stream_duplex.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,16 @@ Object.defineProperty(Duplex.prototype, 'writableFinished', {
}
});

Object.defineProperty(Duplex.prototype, 'writableCorked', {
// Making it explicit this property is not enumerable
// because otherwise some prototype manipulation in
// userland will fail
enumerable: false,
get() {
return this._writableState ? this._writableState.corked : 0;
}
});

Object.defineProperty(Duplex.prototype, 'writableEnded', {
// Making it explicit this property is not enumerable
// because otherwise some prototype manipulation in
Expand Down